iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

atm: Bad locking on br2684_devs modifications.

Browse Source 
The list_del happens under read-locked devs_lock.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Pavel Emelyanov 2008-05-04 18:00:36 -07:00 committed by David S. Miller
parent 65e4113684
commit 1e0ba0060f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
net/atm/br2684.c
View File

@ -346,9 +346,9 @@ static void br2684_push(struct atm_vcc *atmvcc, struct sk_buff *skb)
/* skb==NULL means VCC is being destroyed */
br2684_close_vcc(brvcc);
if (list_empty(&brdev->brvccs)) {
read_lock(&devs_lock);
write_lock_irq(&devs_lock);
list_del(&brdev->br2684_devs);
read_unlock(&devs_lock);
write_unlock_irq(&devs_lock);
unregister_netdev(net_dev);
}
return;