iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drivers: iio: filter: admv8818: add bypass mode

Browse Source 
Add filter bypass mode, which bypasses the low pass filter, high pass
filter and disables/unregister the clock rate notifier.

Currently a feature like bypassing the filter is not achievable
straightforward and not very deductive. The user has to look through the
code and call the set_lpf_3db_frequency and set_hpf_3db_frequency iio
attributes from the user interface using the corner cases (freq >
largest lpf supported by the part, respectively freq < smallest hpf
supported by the part). Moreover, in such case of bypassing the filter,
the input clock rate change might mess up things so we want to make sure
that it is disabled. Also, the feature will help emphasizing the filter
behavior, therefore adding it in the userspace will ease the
charcaterization of the filter's effects when active/disabled.

It was requested by users of the driver to ease the interaction with
different configuration modes of the device.

Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
Link: https://lore.kernel.org/r/20230731084928.8302-1-antoniu.miclaus@analog.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
This commit is contained in:
Antoniu Miclaus 2023-07-31 11:49:26 +03:00 committed by Jonathan Cameron
parent fdb48f9d1a
commit 1ed8775496
1 changed files with 56 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

65
drivers/iio/filter/admv8818.c
View File

@ -78,6 +78,7 @@ enum {
enum { enum {
ADMV8818_AUTO_MODE, ADMV8818_AUTO_MODE,
ADMV8818_MANUAL_MODE, ADMV8818_MANUAL_MODE,
ADMV8818_BYPASS_MODE,
}; };
struct admv8818_state { struct admv8818_state {
@ -114,7 +115,8 @@ static const struct regmap_config admv8818_regmap_config = {
static const char * const admv8818_modes[] = { static const char * const admv8818_modes[] = {
[0] = "auto", [0] = "auto",
[1] = "manual" [1] = "manual",
[2] = "bypass"
}; };
static int __admv8818_hpf_select(struct admv8818_state *st, u64 freq) static int __admv8818_hpf_select(struct admv8818_state *st, u64 freq)
@ -394,6 +396,36 @@ static int admv8818_reg_access(struct iio_dev *indio_dev,
return regmap_write(st->regmap, reg, write_val); return regmap_write(st->regmap, reg, write_val);
} }
static int admv8818_filter_bypass(struct admv8818_state *st)
{
int ret;
mutex_lock(&st->lock);
ret = regmap_update_bits(st->regmap, ADMV8818_REG_WR0_SW,
ADMV8818_SW_IN_SET_WR0_MSK |
ADMV8818_SW_IN_WR0_MSK |
ADMV8818_SW_OUT_SET_WR0_MSK |
ADMV8818_SW_OUT_WR0_MSK,
FIELD_PREP(ADMV8818_SW_IN_SET_WR0_MSK, 1) |
FIELD_PREP(ADMV8818_SW_IN_WR0_MSK, 0) |
FIELD_PREP(ADMV8818_SW_OUT_SET_WR0_MSK, 1) |
FIELD_PREP(ADMV8818_SW_OUT_WR0_MSK, 0));
if (ret)
goto exit;
ret = regmap_update_bits(st->regmap, ADMV8818_REG_WR0_FILTER,
ADMV8818_HPF_WR0_MSK |
ADMV8818_LPF_WR0_MSK,
FIELD_PREP(ADMV8818_HPF_WR0_MSK, 0) |
FIELD_PREP(ADMV8818_LPF_WR0_MSK, 0));
exit:
mutex_unlock(&st->lock);
return ret;
}
static int admv8818_get_mode(struct iio_dev *indio_dev, static int admv8818_get_mode(struct iio_dev *indio_dev,
const struct iio_chan_spec *chan) const struct iio_chan_spec *chan)
{ {
@ -411,14 +443,22 @@ static int admv8818_set_mode(struct iio_dev *indio_dev,
if (!st->clkin) { if (!st->clkin) {
if (mode == ADMV8818_MANUAL_MODE) if (mode == ADMV8818_MANUAL_MODE)
return 0; goto set_mode;
if (mode == ADMV8818_BYPASS_MODE) {
ret = admv8818_filter_bypass(st);
if (ret)
return ret;
goto set_mode;
}
return -EINVAL; return -EINVAL;
} }
switch (mode) { switch (mode) {
case ADMV8818_AUTO_MODE: case ADMV8818_AUTO_MODE:
if (!st->filter_mode) if (st->filter_mode == ADMV8818_AUTO_MODE)
return 0; return 0;
ret = clk_prepare_enable(st->clkin); ret = clk_prepare_enable(st->clkin);
@ -434,20 +474,27 @@ static int admv8818_set_mode(struct iio_dev *indio_dev,
break; break;
case ADMV8818_MANUAL_MODE: case ADMV8818_MANUAL_MODE:
if (st->filter_mode) case ADMV8818_BYPASS_MODE:
return 0; if (st->filter_mode == ADMV8818_AUTO_MODE) {
clk_disable_unprepare(st->clkin);
clk_disable_unprepare(st->clkin); ret = clk_notifier_unregister(st->clkin, &st->nb);
if (ret)
return ret;
}
ret = clk_notifier_unregister(st->clkin, &st->nb); if (mode == ADMV8818_BYPASS_MODE) {
if (ret) ret = admv8818_filter_bypass(st);
return ret; if (ret)
return ret;
}
break; break;
default: default:
return -EINVAL; return -EINVAL;
} }
set_mode:
st->filter_mode = mode; st->filter_mode = mode;
return ret; return ret;