iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

power: supply: sc27xx: Replace devm_add_action() followed by failure action with devm_add_action_or_reset()

Browse Source 
devm_add_action_or_reset() is introduced as a helper function which
internally calls devm_add_action(). If devm_add_action() fails
then it will execute the action mentioned and return the error code.
This reduce source code size (avoid writing the action twice)
and reduce the likelyhood of bugs.

Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
Reviewed-by: Baolin Wang <baolin.wang@linaro.org>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
This commit is contained in:
Fuqian Huang 2019-07-08 20:32:59 +08:00 committed by Sebastian Reichel
parent 08614b407d
commit 204205836f
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/power/supply/sc27xx_fuel_gauge.c
View File

@ -1023,9 +1023,8 @@ static int sc27xx_fgu_probe(struct platform_device *pdev)
return ret;
}
ret = devm_add_action(dev, sc27xx_fgu_disable, data);
ret = devm_add_action_or_reset(dev, sc27xx_fgu_disable, data);
if (ret) {
sc27xx_fgu_disable(data);
dev_err(dev, "failed to add fgu disable action\n");
return ret;
}