iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

powerpc/fadump: Use swap() instead of open coding it

Browse Source 
Clean the following coccicheck warning:

./arch/powerpc/kernel/fadump.c:1291:34-35: WARNING opportunity for
swap().

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220129034847.76902-1-jiapeng.chong@linux.alibaba.com
This commit is contained in:
Jiapeng Chong 2022-01-29 11:48:47 +08:00 committed by Michael Ellerman
parent e9bb94cde1
commit 2077631917
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
arch/powerpc/kernel/fadump.c
View File

@ -1285,7 +1285,6 @@ static void fadump_release_reserved_area(u64 start, u64 end)
static void sort_and_merge_mem_ranges(struct fadump_mrange_info *mrange_info) static void sort_and_merge_mem_ranges(struct fadump_mrange_info *mrange_info)
{ {
struct fadump_memory_range *mem_ranges; struct fadump_memory_range *mem_ranges;
struct fadump_memory_range tmp_range;
u64 base, size; u64 base, size;
int i, j, idx; int i, j, idx;
@ -1300,11 +1299,8 @@ static void sort_and_merge_mem_ranges(struct fadump_mrange_info *mrange_info)
if (mem_ranges[idx].base > mem_ranges[j].base) if (mem_ranges[idx].base > mem_ranges[j].base)
idx = j; idx = j;
} }
if (idx != i) { if (idx != i)
tmp_range = mem_ranges[idx]; swap(mem_ranges[idx], mem_ranges[i]);
mem_ranges[idx] = mem_ranges[i];
mem_ranges[i] = tmp_range;
}
} }
/* Merge adjacent reserved ranges */ /* Merge adjacent reserved ranges */