iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

scsi: st: mark expected switch fall-throughs

Browse Source 
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where
we are expecting to fall through.

Addresses-Coverity-ID: 114994 ("Missing break in switch")
Addresses-Coverity-ID: 114995 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Kai Mäkisara <kai.makisara@kolumbus.fi>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Gustavo A. R. Silva 2018-11-27 22:33:54 -06:00 committed by Martin K. Petersen
parent fc9ac87eab
commit 211d62a8ce
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/scsi/st.c
View File

@ -337,12 +337,14 @@ static void st_analyze_sense(struct st_request *SRpnt, struct st_cmdstatus *s)
switch (sense[0] & 0x7f) { switch (sense[0] & 0x7f) {
case 0x71: case 0x71:
s->deferred = 1; s->deferred = 1;
/* fall through */
case 0x70: case 0x70:
s->fixed_format = 1; s->fixed_format = 1;
s->flags = sense[2] & 0xe0; s->flags = sense[2] & 0xe0;
break; break;
case 0x73: case 0x73:
s->deferred = 1; s->deferred = 1;
/* fall through */
case 0x72: case 0x72:
s->fixed_format = 0; s->fixed_format = 0;
ucp = scsi_sense_desc_find(sense, SCSI_SENSE_BUFFERSIZE, 4); ucp = scsi_sense_desc_find(sense, SCSI_SENSE_BUFFERSIZE, 4);
@ -2721,6 +2723,7 @@ static int st_int_ioctl(struct scsi_tape *STp, unsigned int cmd_in, unsigned lon
switch (cmd_in) { switch (cmd_in) {
case MTFSFM: case MTFSFM:
chg_eof = 0; /* Changed from the FSF after this */ chg_eof = 0; /* Changed from the FSF after this */
/* fall through */
case MTFSF: case MTFSF:
cmd[0] = SPACE; cmd[0] = SPACE;
cmd[1] = 0x01; /* Space FileMarks */ cmd[1] = 0x01; /* Space FileMarks */
@ -2735,6 +2738,7 @@ static int st_int_ioctl(struct scsi_tape *STp, unsigned int cmd_in, unsigned lon
break; break;
case MTBSFM: case MTBSFM:
chg_eof = 0; /* Changed from the FSF after this */ chg_eof = 0; /* Changed from the FSF after this */
/* fall through */
case MTBSF: case MTBSF:
cmd[0] = SPACE; cmd[0] = SPACE;
cmd[1] = 0x01; /* Space FileMarks */ cmd[1] = 0x01; /* Space FileMarks */