iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[POWERPC] Inline u3msi_compose_msi_msg()

Browse Source 
In the MPIC U3 MSI code, we call u3msi_compose_msi_msg() once for each MSI.
This is overkill, as the address is per pci device, not per MSI. So setup
the address once, and just set the data per MSI.

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>
This commit is contained in:
Michael Ellerman 2007-09-20 16:36:51 +10:00 committed by Paul Mackerras
parent d385366a9b
commit 21ccdd31e9
1 changed files with 9 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
arch/powerpc/sysdev/mpic_u3msi.c
View File

@ -108,26 +108,17 @@ static void u3msi_teardown_msi_irqs(struct pci_dev *pdev)
return;
}
static void u3msi_compose_msi_msg(struct pci_dev *pdev, int virq,
struct msi_msg *msg)
{
u64 addr;
addr = find_ht_magic_addr(pdev);
msg->address_lo = addr & 0xFFFFFFFF;
msg->address_hi = addr >> 32;
msg->data = virq_to_hw(virq);
pr_debug("u3msi: allocated virq 0x%x (hw 0x%lx) at address 0x%lx\n",
virq, virq_to_hw(virq), addr);
}
static int u3msi_setup_msi_irqs(struct pci_dev *pdev, int nvec, int type)
{
irq_hw_number_t hwirq;
unsigned int virq;
struct msi_desc *entry;
struct msi_msg msg;
u64 addr;
addr = find_ht_magic_addr(pdev);
msg.address_lo = addr & 0xFFFFFFFF;
msg.address_hi = addr >> 32;
list_for_each_entry(entry, &pdev->msi_list, list) {
hwirq = mpic_msi_alloc_hwirqs(msi_mpic, 1);
@ -147,7 +138,10 @@ static int u3msi_setup_msi_irqs(struct pci_dev *pdev, int nvec, int type)
set_irq_chip(virq, &mpic_u3msi_chip);
set_irq_type(virq, IRQ_TYPE_EDGE_RISING);
u3msi_compose_msi_msg(pdev, virq, &msg);
pr_debug("u3msi: allocated virq 0x%x (hw 0x%lx) addr 0x%lx\n",
virq, hwirq, addr);
msg.data = hwirq;
write_msi_msg(virq, &msg);
hwirq++;