iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

misc: sram: Generate unique names for subpools

Browse Source 
The current code will, if we do not specify unique labels
for the SRAM subnodes, fail to register several nodes named
the same.

Example:

sram@40020000 {
  (...)
  sram@0 {
    (...)
  };
  sram@1000 {
    (...)
  };
};

Since the child->name in both cases will be "sram" the
gen_pool_create() will fail because the name is not unique.

Use dev_name() for the device as this will have bus ID
set to the fully translated address for the node, and that
will always be unique.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20230417-ux500-sram-v2-2-6e62ad551faa@linaro.org
This commit is contained in:
Linus Walleij 2023-04-20 23:17:35 +02:00
parent 38bd22dac7
commit 21e5a2d10c
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/misc/sram.c
View File

@ -235,10 +235,11 @@ static int sram_reserve_regions(struct sram_dev *sram, struct resource *res)
goto err_chunks; goto err_chunks;
} }
if (!label) if (!label)
label = child->name; block->label = devm_kasprintf(sram->dev, GFP_KERNEL,
"%s", dev_name(sram->dev));
block->label = devm_kstrdup(sram->dev, else
label, GFP_KERNEL); block->label = devm_kstrdup(sram->dev,
label, GFP_KERNEL);
if (!block->label) { if (!block->label) {
ret = -ENOMEM; ret = -ENOMEM;
goto err_chunks; goto err_chunks;