iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qlcnic: Fix CPU soft lockup while collecting firmware dump

Browse Source 
Driver while collecting firmware dump takes longer time to
collect/process some of the firmware dump entries/memories.
Bigger capture masks makes it worse as it results in larger
amount of data being collected and results in CPU soft lockup.
Place cond_resched() in some of the driver flows that are
expectedly time consuming to relinquish the CPU to avoid CPU
soft lockup panic.

Signed-off-by: Shahed Shaikh <shshaikh@marvell.com>
Tested-by: Yonggen Xu <Yonggen.Xu@dell.com>
Signed-off-by: Manish Chopra <manishc@marvell.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Manish Chopra 2020-01-22 01:43:38 -08:00 committed by David S. Miller
parent bb48eb9b12
commit 22e984493a
2 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c
View File

@ -2043,6 +2043,7 @@ static void qlcnic_83xx_exec_template_cmd(struct qlcnic_adapter *p_dev,
break; break;
} }
entry += p_hdr->size; entry += p_hdr->size;
cond_resched();
} }
p_dev->ahw->reset.seq_index = index; p_dev->ahw->reset.seq_index = index;
} }

2
drivers/net/ethernet/qlogic/qlcnic/qlcnic_minidump.c
View File

@ -703,6 +703,7 @@ static u32 qlcnic_read_memory_test_agent(struct qlcnic_adapter *adapter,
addr += 16; addr += 16;
reg_read -= 16; reg_read -= 16;
ret += 16; ret += 16;
cond_resched();
} }
out: out:
mutex_unlock(&adapter->ahw->mem_lock); mutex_unlock(&adapter->ahw->mem_lock);
@ -1383,6 +1384,7 @@ int qlcnic_dump_fw(struct qlcnic_adapter *adapter)
buf_offset += entry->hdr.cap_size; buf_offset += entry->hdr.cap_size;
entry_offset += entry->hdr.offset; entry_offset += entry->hdr.offset;
buffer = fw_dump->data + buf_offset; buffer = fw_dump->data + buf_offset;
cond_resched();
} }
fw_dump->clr = 1; fw_dump->clr = 1;