iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

USB: serial: metro-usb: stop I/O after failed open

Browse Source 
Make sure to kill the interrupt-in URB after a failed open request.
Apart from saving power (and avoiding stale input after a later
successful open), this also prevents a NULL-deref in the completion
handler if the port is manually unbound.

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fixes: 704577861d5e ("USB: serial: metro-usb: get data from device in Uni-Directional mode.")
Cc: stable <stable@vger.kernel.org>	# 3.5
Signed-off-by: Johan Hovold <johan@kernel.org>
This commit is contained in:
Johan Hovold 2017-10-12 10:54:21 +02:00
parent 9eabd28e8b
commit 2339536d22
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/usb/serial/metro-usb.c
View File

@ -188,7 +188,7 @@ static int metrousb_open(struct tty_struct *tty, struct usb_serial_port *port)
dev_err(&port->dev, dev_err(&port->dev,
"%s - failed submitting interrupt in urb, error code=%d\n", "%s - failed submitting interrupt in urb, error code=%d\n",
__func__, result); __func__, result);
goto exit; return result;
} }
/* Send activate cmd to device */ /* Send activate cmd to device */
@ -197,9 +197,14 @@ static int metrousb_open(struct tty_struct *tty, struct usb_serial_port *port)
dev_err(&port->dev, dev_err(&port->dev,
"%s - failed to configure device, error code=%d\n", "%s - failed to configure device, error code=%d\n",
__func__, result); __func__, result);
goto exit; goto err_kill_urb;
} }
exit:
return 0;
err_kill_urb:
usb_kill_urb(port->interrupt_in_urb);
return result; return result;
} }