iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

clocksource: Fix 'ret' data type of sysfs_override_clocksource() and sysfs_unbind_clocksource()

Browse Source 
sysfs_override_clocksource(): The expression 'if (ret >= 0)' is always true.
This will cause clocksource_select() to always run.
Thus modified ret to be of type ssize_t.

sysfs_unbind_clocksource(): The expression 'if (ret < 0)' is always false.
So in case sysfs_get_uname() failed, the expression won't take an effect.
Thus modified ret to be of type ssize_t.

Signed-off-by: Elad Wexler <elad.wexler@gmail.com>
Signed-off-by: John Stultz <john.stultz@linaro.org>
This commit is contained in:
Elad Wexler 2013-09-12 13:28:54 +03:00 committed by John Stultz
parent 389e067032
commit 233bcb411c
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
kernel/time/clocksource.c
View File

@ -940,7 +940,7 @@ static ssize_t sysfs_override_clocksource(struct device *dev,
struct device_attribute *attr, struct device_attribute *attr,
const char *buf, size_t count) const char *buf, size_t count)
{ {
size_t ret; ssize_t ret;
mutex_lock(&clocksource_mutex); mutex_lock(&clocksource_mutex);
@ -968,7 +968,7 @@ static ssize_t sysfs_unbind_clocksource(struct device *dev,
{ {
struct clocksource *cs; struct clocksource *cs;
char name[CS_NAME_LEN]; char name[CS_NAME_LEN];
size_t ret; ssize_t ret;
ret = sysfs_get_uname(buf, name, count); ret = sysfs_get_uname(buf, name, count);
if (ret < 0) if (ret < 0)