iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

greybus: protocol: fix oops when no protocol is assigned

Browse Source 
When removing a connection with no protocol assigned to it, the kernel
oopses as we always thought protocols were always there.

Fix that problem, oopses are bad.

Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
Reviewed-by: Alex Elder <elder@linaro.org>
This commit is contained in:
Greg Kroah-Hartman 2014-12-24 13:12:10 -08:00
parent 7422a1ec2e
commit 23ad7bb96b
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/staging/greybus/protocol.c
View File

@ -165,10 +165,16 @@ struct gb_protocol *gb_protocol_get(u8 id, u8 major, u8 minor)
void gb_protocol_put(struct gb_protocol *protocol)
{
u8 major = protocol->major;
u8 minor = protocol->minor;
u8 major;
u8 minor;
u8 protocol_count;
if (!protocol)
return;
major = protocol->major;
minor = protocol->minor;
spin_lock_irq(&gb_protocols_lock);
protocol = _gb_protocol_find(protocol->id, protocol->major,
protocol->minor);