iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

phy: tegra: xusb: Remove usb3 supply

Browse Source 
Remove redundant codes for getting the vbus supply of usb3 ports because
we get and control the vbus supply by the companion usb2 ports

Signed-off-by: Wayne Chang <waynec@nvidia.com>
Signed-off-by: Haotien Hsu <haotienh@nvidia.com>
Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Link: https://lore.kernel.org/r/20221005084031.2154251-1-haotienh@nvidia.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
Wayne Chang 2022-10-05 16:40:31 +08:00 committed by Vinod Koul
parent 53bffe0055
commit 2428787f16
5 changed files with 1 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/phy/tegra/xusb-tegra124.c
View File

@ -1652,7 +1652,6 @@ tegra124_usb3_port_map(struct tegra_xusb_port *port)
static const struct tegra_xusb_port_ops tegra124_usb3_port_ops = { static const struct tegra_xusb_port_ops tegra124_usb3_port_ops = {
.release = tegra_xusb_usb3_port_release, .release = tegra_xusb_usb3_port_release,
.remove = tegra_xusb_usb3_port_remove,
.enable = tegra124_usb3_port_enable, .enable = tegra124_usb3_port_enable,
.disable = tegra124_usb3_port_disable, .disable = tegra124_usb3_port_disable,
.map = tegra124_usb3_port_map, .map = tegra124_usb3_port_map,

1
drivers/phy/tegra/xusb-tegra186.c
View File

@ -1185,7 +1185,6 @@ tegra186_usb3_port_map(struct tegra_xusb_port *port)
static const struct tegra_xusb_port_ops tegra186_usb3_port_ops = { static const struct tegra_xusb_port_ops tegra186_usb3_port_ops = {
.release = tegra_xusb_usb3_port_release, .release = tegra_xusb_usb3_port_release,
.remove = tegra_xusb_usb3_port_remove,
.enable = tegra186_usb3_port_enable, .enable = tegra186_usb3_port_enable,
.disable = tegra186_usb3_port_disable, .disable = tegra186_usb3_port_disable,
.map = tegra186_usb3_port_map, .map = tegra186_usb3_port_map,

1
drivers/phy/tegra/xusb-tegra210.c
View File

@ -3078,7 +3078,6 @@ tegra210_usb3_port_map(struct tegra_xusb_port *port)
static const struct tegra_xusb_port_ops tegra210_usb3_port_ops = { static const struct tegra_xusb_port_ops tegra210_usb3_port_ops = {
.release = tegra_xusb_usb3_port_release, .release = tegra_xusb_usb3_port_release,
.remove = tegra_xusb_usb3_port_remove,
.enable = tegra210_usb3_port_enable, .enable = tegra210_usb3_port_enable,
.disable = tegra210_usb3_port_disable, .disable = tegra210_usb3_port_disable,
.map = tegra210_usb3_port_map, .map = tegra210_usb3_port_map,

10
drivers/phy/tegra/xusb.c
View File

@ -954,8 +954,7 @@ static int tegra_xusb_usb3_port_parse_dt(struct tegra_xusb_usb3_port *usb3)
return -EINVAL; return -EINVAL;
} }
usb3->supply = regulator_get(&port->dev, "vbus"); return 0;
return PTR_ERR_OR_ZERO(usb3->supply);
} }
static int tegra_xusb_add_usb3_port(struct tegra_xusb_padctl *padctl, static int tegra_xusb_add_usb3_port(struct tegra_xusb_padctl *padctl,
@ -1012,13 +1011,6 @@ void tegra_xusb_usb3_port_release(struct tegra_xusb_port *port)
kfree(usb3); kfree(usb3);
} }
void tegra_xusb_usb3_port_remove(struct tegra_xusb_port *port)
{
struct tegra_xusb_usb3_port *usb3 = to_usb3_port(port);
regulator_put(usb3->supply);
}
static void __tegra_xusb_remove_ports(struct tegra_xusb_padctl *padctl) static void __tegra_xusb_remove_ports(struct tegra_xusb_padctl *padctl)
{ {
struct tegra_xusb_port *port, *tmp; struct tegra_xusb_port *port, *tmp;

2
drivers/phy/tegra/xusb.h
View File

@ -359,7 +359,6 @@ void tegra_xusb_hsic_port_release(struct tegra_xusb_port *port);
struct tegra_xusb_usb3_port { struct tegra_xusb_usb3_port {
struct tegra_xusb_port base; struct tegra_xusb_port base;
struct regulator *supply;
bool context_saved; bool context_saved;
unsigned int port; unsigned int port;
bool internal; bool internal;
@ -381,7 +380,6 @@ struct tegra_xusb_usb3_port *
tegra_xusb_find_usb3_port(struct tegra_xusb_padctl *padctl, tegra_xusb_find_usb3_port(struct tegra_xusb_padctl *padctl,
unsigned int index); unsigned int index);
void tegra_xusb_usb3_port_release(struct tegra_xusb_port *port); void tegra_xusb_usb3_port_release(struct tegra_xusb_port *port);
void tegra_xusb_usb3_port_remove(struct tegra_xusb_port *port);
struct tegra_xusb_port_ops { struct tegra_xusb_port_ops {
void (*release)(struct tegra_xusb_port *port); void (*release)(struct tegra_xusb_port *port);