iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pinctrl: qcom-spmi-gpio: Fix input value report

Browse Source 
Read input buffer when input is enabled, not when it is
disabled. Also fix interpretation of the pmic_gpio_read()
return code, negative value means an error.

Signed-off-by: Ivan T. Ivanov <ivan.ivanov@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Ivan T. Ivanov 2015-04-09 18:18:36 +03:00 committed by Linus Walleij
parent 982df6aec0
commit 24a66618d6
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
View File

@ -466,12 +466,13 @@ static void pmic_gpio_config_dbg_show(struct pinctrl_dev *pctldev,
seq_puts(s, " ---"); seq_puts(s, " ---");
} else { } else {
if (!pad->input_enabled) { if (pad->input_enabled) {
ret = pmic_gpio_read(state, pad, PMIC_MPP_REG_RT_STS); ret = pmic_gpio_read(state, pad, PMIC_MPP_REG_RT_STS);
if (!ret) { if (ret < 0)
ret &= PMIC_MPP_REG_RT_STS_VAL_MASK; return;
pad->out_value = ret;
} ret &= PMIC_MPP_REG_RT_STS_VAL_MASK;
pad->out_value = ret;
} }
seq_printf(s, " %-4s", pad->output_enabled ? "out" : "in"); seq_printf(s, " %-4s", pad->output_enabled ? "out" : "in");