iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Input: synaptics-rmi4 - fix endianness issue in SMBus transport

Browse Source 
The mapping table holds address in LE form, so we should convert it
to CPU when comparing it.

Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
This commit is contained in:
Dmitry Torokhov 2017-03-24 12:34:20 -07:00
parent 8cf0adf2f8
commit 2593cd1189
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/input/rmi4/rmi_smbus.c
View File

@ -89,17 +89,17 @@ static int rmi_smb_get_command_code(struct rmi_transport_dev *xport,
mutex_lock(&rmi_smb->mappingtable_mutex); mutex_lock(&rmi_smb->mappingtable_mutex);
for (i = 0; i < RMI_SMB2_MAP_SIZE; i++) { for (i = 0; i < RMI_SMB2_MAP_SIZE; i++) {
if (rmi_smb->mapping_table[i].rmiaddr == rmiaddr) { struct mapping_table_entry *entry = &rmi_smb->mapping_table[i];
if (le16_to_cpu(entry->rmiaddr) == rmiaddr) {
if (isread) { if (isread) {
if (rmi_smb->mapping_table[i].readcount if (entry->readcount == bytecount) {
== bytecount) {
*commandcode = i; *commandcode = i;
retval = 0; retval = 0;
goto exit; goto exit;
} }
} else { } else {
if (rmi_smb->mapping_table[i].flags & if (entry->flags & RMI_SMB2_MAP_FLAGS_WE) {
RMI_SMB2_MAP_FLAGS_WE) {
*commandcode = i; *commandcode = i;
retval = 0; retval = 0;
goto exit; goto exit;