iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mm/oom_kill: change comment and rename is_dump_unreclaim_slabs()

Browse Source 
Change the comment of is_dump_unreclaim_slabs(), it just check whether
nr_unreclaimable slabs amount is greater than user memory, and explain why
we dump unreclaim slabs.

Rename it to should_dump_unreclaim_slab() maybe better.

Link: https://lkml.kernel.org/r/20201030182704.GA53949@rlk
Signed-off-by: Hui Su <sh_def@163.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Hui Su 2020-12-14 19:12:49 -08:00 committed by Linus Torvalds
parent 2271b016bf
commit 259b3633e7
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
mm/oom_kill.c
View File

@ -170,11 +170,13 @@ static bool oom_unkillable_task(struct task_struct *p)
return false; return false;
} }
/* /**
* Print out unreclaimble slabs info when unreclaimable slabs amount is greater * Check whether unreclaimable slab amount is greater than
* than all user memory (LRU pages) * all user memory(LRU pages).
*/ * dump_unreclaimable_slab() could help in the case that
static bool is_dump_unreclaim_slabs(void) * oom due to too much unreclaimable slab used by kernel.
*/
static bool should_dump_unreclaim_slab(void)
{ {
unsigned long nr_lru; unsigned long nr_lru;
@ -463,7 +465,7 @@ static void dump_header(struct oom_control *oc, struct task_struct *p)
mem_cgroup_print_oom_meminfo(oc->memcg); mem_cgroup_print_oom_meminfo(oc->memcg);
else { else {
show_mem(SHOW_MEM_FILTER_NODES, oc->nodemask); show_mem(SHOW_MEM_FILTER_NODES, oc->nodemask);
if (is_dump_unreclaim_slabs()) if (should_dump_unreclaim_slab())
dump_unreclaimable_slab(); dump_unreclaimable_slab();
} }
if (sysctl_oom_dump_tasks) if (sysctl_oom_dump_tasks)