iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

staging: wilc1000: avoid 'NULL' pointer access in wilc_network_info_received()

Browse Source 
Added 'NULL' check before accessing the allocated memory. Free up the
memory incase of failure to enqueue the command. Used kmemdup instead of
kmalloc & memcpy.

Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Ajay Singh 2018-03-26 17:15:56 +05:30 committed by Greg Kroah-Hartman
parent 56294f8714
commit 25b951332d
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/staging/wilc1000/host_interface.c
View File

@ -3465,12 +3465,15 @@ void wilc_network_info_received(struct wilc *wilc, u8 *buffer, u32 length)
msg.vif = vif;
msg.body.net_info.len = length;
msg.body.net_info.buffer = kmalloc(length, GFP_KERNEL);
memcpy(msg.body.net_info.buffer, buffer, length);
msg.body.net_info.buffer = kmemdup(buffer, length, GFP_KERNEL);
if (!msg.body.net_info.buffer)
return;
result = wilc_enqueue_cmd(&msg);
if (result)
if (result) {
netdev_err(vif->ndev, "message parameters (%d)\n", result);
kfree(msg.body.net_info.buffer);
}
}
void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *buffer, u32 length)