iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Btrfs: fix an oops when we fail to merge reloc roots

Browse Source 
Previously, we will free reloc root memory and then force filesystem
to be readonly. The problem is that there may be another thread commiting
transaction which will try to access freed reloc root during merging reloc
roots process.

To keep consistency snapshots shared space, we should allow snapshot
finished if possible, so here we don't free reloc root memory.

signed-off-by: Wang Shilong <wangsl.fnst@cn.fujitsu.com>

Signed-off-by: Josef Bacik <jbacik@fb.com>
Signed-off-by: Chris Mason <clm@fb.com>
This commit is contained in:
Wang Shilong 2013-12-26 13:10:50 +08:00 committed by Chris Mason
parent dc4103f933
commit 25e293c2a2
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
fs/btrfs/relocation.c
View File

@ -2311,9 +2311,6 @@ void free_reloc_roots(struct list_head *list)
reloc_root = list_entry(list->next, struct btrfs_root, reloc_root = list_entry(list->next, struct btrfs_root,
root_list); root_list);
__del_reloc_root(reloc_root); __del_reloc_root(reloc_root);
free_extent_buffer(reloc_root->node);
free_extent_buffer(reloc_root->commit_root);
kfree(reloc_root);
} }
} }
@ -2355,10 +2352,9 @@ again:
ret = merge_reloc_root(rc, root); ret = merge_reloc_root(rc, root);
if (ret) { if (ret) {
__del_reloc_root(reloc_root); if (list_empty(&reloc_root->root_list))
free_extent_buffer(reloc_root->node); list_add_tail(&reloc_root->root_list,
free_extent_buffer(reloc_root->commit_root); &reloc_roots);
kfree(reloc_root);
goto out; goto out;
} }
} else { } else {