iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

crypto: geode - use DEFINE_SPINLOCK() for spinlock

Browse Source 
spinlock can be initialized automatically with DEFINE_SPINLOCK()
rather than explicitly calling spin_lock_init().

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Guobin Huang <huangguobin4@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Guobin Huang 2021-04-06 20:00:03 +08:00 committed by Herbert Xu
parent fa07c1a30b
commit 25ee76a221
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/crypto/geode-aes.c
View File

@ -21,7 +21,7 @@
/* Static structures */ /* Static structures */
static void __iomem *_iobase; static void __iomem *_iobase;
static spinlock_t lock; static DEFINE_SPINLOCK(lock);
/* Write a 128 bit field (either a writable key or IV) */ /* Write a 128 bit field (either a writable key or IV) */
static inline void static inline void
@ -383,8 +383,6 @@ static int geode_aes_probe(struct pci_dev *dev, const struct pci_device_id *id)
goto erequest; goto erequest;
} }
spin_lock_init(&lock);
/* Clear any pending activity */ /* Clear any pending activity */
iowrite32(AES_INTR_PENDING | AES_INTR_MASK, _iobase + AES_INTR_REG); iowrite32(AES_INTR_PENDING | AES_INTR_MASK, _iobase + AES_INTR_REG);