iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

platform/x86: wmi: replace usage of found with dedicated list iterator variable

Browse Source 
To move the list iterator variable into the list_for_each_entry_*()
macro in the future it should be avoided to use the list iterator
variable after the loop body.

To *never* use the list iterator variable after the loop it was
concluded to use a separate iterator variable instead of a
found boolean [1].

This removes the need to use a found variable and simply checking if
the variable was set, can determine if the break/goto was hit.

Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/
Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
Link: https://lore.kernel.org/r/20220324072015.62063-1-jakobkoschel@gmail.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
This commit is contained in:
Jakob Koschel 2022-03-24 08:20:15 +01:00 committed by Hans de Goede
parent 34354476f0
commit 264e8de27b
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/platform/x86/wmi.c
View File

@ -1308,21 +1308,20 @@ acpi_wmi_ec_space_handler(u32 function, acpi_physical_address address,
static void acpi_wmi_notify_handler(acpi_handle handle, u32 event, static void acpi_wmi_notify_handler(acpi_handle handle, u32 event,
void *context) void *context)
{ {
struct wmi_block *wblock; struct wmi_block *wblock = NULL, *iter;
bool found_it = false;
list_for_each_entry(wblock, &wmi_block_list, list) { list_for_each_entry(iter, &wmi_block_list, list) {
struct guid_block *block = &wblock->gblock; struct guid_block *block = &iter->gblock;
if (wblock->acpi_device->handle == handle && if (iter->acpi_device->handle == handle &&
(block->flags & ACPI_WMI_EVENT) && (block->flags & ACPI_WMI_EVENT) &&
(block->notify_id == event)) { (block->notify_id == event)) {
found_it = true; wblock = iter;
break; break;
} }
} }
if (!found_it) if (!wblock)
return; return;
/* If a driver is bound, then notify the driver. */ /* If a driver is bound, then notify the driver. */