iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

uapi nbd: add cookie alias to handle

Browse Source 
The uapi <linux/nbd.h> header declares a 'char handle[8]' per request;
which is overloaded in English (are you referring to "handle" the
verb, such as handling a signal or writing a callback handler, or
"handle" the noun, the value used in a lookup table to correlate a
response back to the request).  Many user-space NBD implementations
(both servers and clients) have instead used 'uint64_t cookie' or
similar, as it is easier to directly assign an integer than to futz
around with memcpy.  In fact, upstream documentation is now
encouraging this shift in terminology:
https://github.com/NetworkBlockDevice/nbd/commit/ca4392eb2b

Accomplish this by use of an anonymous union to provide the alias for
anyone getting the definition from the uapi; this does not break
existing clients, while exposing the nicer name for those who prefer
it.  Note that block/nbd.c still uses the term handle (in fact, it
actually combines a 32-bit cookie and a 32-bit tag into the 64-bit
handle), but that internal usage is not changed by the public uapi,
since no compliant NBD server has any reason to inspect or alter the
64 bits sent over the socket.

Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Link: https://lore.kernel.org/r/20230410180611.1051618-3-eblake@redhat.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Eric Blake 2023-04-10 13:06:09 -05:00 committed by Jens Axboe
parent daf376a366
commit 2686eb845d
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
include/uapi/linux/nbd.h
View File

@ -12,7 +12,7 @@
* 2004/02/19 Paul Clements
* Removed PARANOIA, plus various cleanup and comments
* 2023 Copyright Red Hat
* Link to userspace extensions.
* Link to userspace extensions, favor cookie over handle.
*/
#ifndef _UAPILINUX_NBD_H
@ -81,7 +81,10 @@ enum {
struct nbd_request {
__be32 magic; /* NBD_REQUEST_MAGIC */
__be32 type; /* See NBD_CMD_* */
char handle[8];
union {
__be64 cookie; /* Opaque identifier for request */
char handle[8]; /* older spelling of cookie */
};
__be64 from;
__be32 len;
} __attribute__((packed));
@ -93,6 +96,9 @@ struct nbd_request {
struct nbd_reply {
__be32 magic; /* NBD_REPLY_MAGIC */
__be32 error; /* 0 = ok, else error */
char handle[8]; /* handle you got from request */
union {
__be64 cookie; /* Opaque identifier from request */
char handle[8]; /* older spelling of cookie */
};
};
#endif /* _UAPILINUX_NBD_H */