iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mtd: rawnand: davinci: Rewrite function description

Browse Source 
commit 0697f8441faad552fbeb02d74454b5e7bcc956a2 upstream.

The original comment that describes the function
nand_davinci_read_page_hwecc_oob_first() is very obscure and it is hard
to understand what it is for.

Cc: <stable@vger.kernel.org> # v5.2
Fixes: a0ac778eb82c ("mtd: rawnand: ingenic: Add support for the JZ4740")
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20211016132228.40254-3-paul@crapouillou.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Paul Cercueil 2021-10-16 14:22:26 +01:00 committed by Greg Kroah-Hartman
parent 3f5eb2d890
commit 26aa92a7f9
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/mtd/nand/raw/davinci_nand.c
View File

@ -372,17 +372,15 @@ correct:
} }
/** /**
* nand_read_page_hwecc_oob_first - hw ecc, read oob first * nand_davinci_read_page_hwecc_oob_first - Hardware ECC page read with ECC
* data read from OOB area
* @chip: nand chip info structure * @chip: nand chip info structure
* @buf: buffer to store read data * @buf: buffer to store read data
* @oob_required: caller requires OOB data read to chip->oob_poi * @oob_required: caller requires OOB data read to chip->oob_poi
* @page: page number to read * @page: page number to read
* *
* Hardware ECC for large page chips, require OOB to be read first. For this * Hardware ECC for large page chips, which requires the ECC data to be
* ECC mode, the write_page method is re-used from ECC_HW. These methods * extracted from the OOB before the actual data is read.
* read/write ECC from the OOB area, unlike the ECC_HW_SYNDROME support with
* multiple ECC steps, follows the "infix ECC" scheme and reads/writes ECC from
* the data area, by overwriting the NAND manufacturer bad block markings.
*/ */
static int nand_davinci_read_page_hwecc_oob_first(struct nand_chip *chip, static int nand_davinci_read_page_hwecc_oob_first(struct nand_chip *chip,
uint8_t *buf, uint8_t *buf,