iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Input: adp5588-keys - use devm_regulator_get_enable()

Browse Source 
Use devm_regulator_get_enable() instead of hand writing it. It saves some
line of code.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Link: https://lore.kernel.org/r/af343b5b0d740cc9f8863264c30e3da4215721d7.1686985911.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
This commit is contained in:
Christophe JAILLET 2023-06-17 09:12:03 +02:00 committed by Dmitry Torokhov
parent 3ce6e06202
commit 26ab82616e
1 changed files with 1 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
drivers/input/keyboard/adp5588-keys.c
View File

@ -713,17 +713,11 @@ static int adp5588_fw_parse(struct adp5588_kpad *kpad)
return 0; return 0;
} }
static void adp5588_disable_regulator(void *reg)
{
regulator_disable(reg);
}
static int adp5588_probe(struct i2c_client *client) static int adp5588_probe(struct i2c_client *client)
{ {
struct adp5588_kpad *kpad; struct adp5588_kpad *kpad;
struct input_dev *input; struct input_dev *input;
struct gpio_desc *gpio; struct gpio_desc *gpio;
struct regulator *vcc;
unsigned int revid; unsigned int revid;
int ret; int ret;
int error; int error;
@ -749,16 +743,7 @@ static int adp5588_probe(struct i2c_client *client)
if (error) if (error)
return error; return error;
vcc = devm_regulator_get(&client->dev, "vcc"); error = devm_regulator_get_enable(&client->dev, "vcc");
if (IS_ERR(vcc))
return PTR_ERR(vcc);
error = regulator_enable(vcc);
if (error)
return error;
error = devm_add_action_or_reset(&client->dev,
adp5588_disable_regulator, vcc);
if (error) if (error)
return error; return error;