iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net: marvell: Replace zero-length array with flexible-array member

Browse Source 
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:

struct foo {
        int stuff;
        struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.

Also, notice that, dynamic memory allocations won't be affected by
this change:

"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]

This issue was found with the help of Coccinelle.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 7649773293 ("cxgb3/l2t: Fix undefined behaviour")

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Gustavo A. R. Silva 2020-02-24 18:12:13 -06:00 committed by David S. Miller
parent c5d6cf903f
commit 274ac2831a
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/ethernet/marvell/skge.h
View File

@ -2426,7 +2426,7 @@ struct skge_hw {
spinlock_t phy_lock;
struct tasklet_struct phy_task;
char irq_name[0]; /* skge@pci:000:04:00.0 */
char irq_name[]; /* skge@pci:000:04:00.0 */
};
enum pause_control {

2
drivers/net/ethernet/marvell/sky2.h
View File

@ -2309,7 +2309,7 @@ struct sky2_hw {
struct work_struct restart_work;
wait_queue_head_t msi_wait;
char irq_name[0];
char irq_name[];
};
static inline int sky2_is_copper(const struct sky2_hw *hw)