iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

powerpc/watchpoints: Annotate atomic context in more places

Browse Source 
It can be easy to miss that the notifier mechanism invokes the callbacks
in an atomic context, so add some comments to that effect on the two
handlers we register here.

Signed-off-by: Benjamin Gray <bgray@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20230829063457.54157-4-bgray@linux.ibm.com
This commit is contained in:
Benjamin Gray 2023-08-29 16:34:57 +10:00 committed by Michael Ellerman
parent 3241f260eb
commit 27646b2e02
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
arch/powerpc/kernel/hw_breakpoint.c
View File

@ -368,6 +368,11 @@ static void handle_p10dd1_spurious_exception(struct perf_event **bp,
} }
} }
/*
* Handle a DABR or DAWR exception.
*
* Called in atomic context.
*/
int hw_breakpoint_handler(struct die_args *args) int hw_breakpoint_handler(struct die_args *args)
{ {
bool err = false; bool err = false;
@ -495,6 +500,8 @@ NOKPROBE_SYMBOL(hw_breakpoint_handler);
/* /*
* Handle single-step exceptions following a DABR hit. * Handle single-step exceptions following a DABR hit.
*
* Called in atomic context.
*/ */
static int single_step_dabr_instruction(struct die_args *args) static int single_step_dabr_instruction(struct die_args *args)
{ {
@ -546,6 +553,8 @@ NOKPROBE_SYMBOL(single_step_dabr_instruction);
/* /*
* Handle debug exception notifications. * Handle debug exception notifications.
*
* Called in atomic context.
*/ */
int hw_breakpoint_exceptions_notify( int hw_breakpoint_exceptions_notify(
struct notifier_block *unused, unsigned long val, void *data) struct notifier_block *unused, unsigned long val, void *data)