iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

xen/gntdev: don't dereference a null gntdev_dmabuf on allocation failure

Browse Source 
Currently when the allocation of gntdev_dmabuf fails, the error exit
path will call dmabuf_imp_free_storage and causes a null pointer
dereference on gntdev_dmabuf.  Fix this by adding an error exit path
that won't free gntdev_dmabuf.

Detected by CoverityScan, CID#1472124 ("Dereference after null check")

Fixes: bf8dc55b13 ("xen/gntdev: Implement dma-buf import functionality")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
This commit is contained in:
Colin Ian King 2018-07-31 15:02:25 +01:00 committed by Boris Ostrovsky
parent 47b428d14f
commit 2789e83c93
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/xen/gntdev-dmabuf.c
View File

@ -569,7 +569,7 @@ static struct gntdev_dmabuf *dmabuf_imp_alloc_storage(int count)
gntdev_dmabuf = kzalloc(sizeof(*gntdev_dmabuf), GFP_KERNEL); gntdev_dmabuf = kzalloc(sizeof(*gntdev_dmabuf), GFP_KERNEL);
if (!gntdev_dmabuf) if (!gntdev_dmabuf)
goto fail; goto fail_no_free;
gntdev_dmabuf->u.imp.refs = kcalloc(count, gntdev_dmabuf->u.imp.refs = kcalloc(count,
sizeof(gntdev_dmabuf->u.imp.refs[0]), sizeof(gntdev_dmabuf->u.imp.refs[0]),
@ -592,6 +592,7 @@ static struct gntdev_dmabuf *dmabuf_imp_alloc_storage(int count)
fail: fail:
dmabuf_imp_free_storage(gntdev_dmabuf); dmabuf_imp_free_storage(gntdev_dmabuf);
fail_no_free:
return ERR_PTR(-ENOMEM); return ERR_PTR(-ENOMEM);
} }