iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mtd: dataflash: Add device-tree SPI IDs

Browse Source 
Commit 5fa6863ba692 ("spi: Check we have a spi_device_id for each DT
compatible") added a test to check that every SPI driver has a
spi_device_id for each DT compatiable string defined by the driver
and warns if the spi_device_id is missing. The spi_device_ids are
missing for the dataflash driver and the following warnings are now
seen.

 WARNING KERN SPI driver mtd_dataflash has no spi_device_id for atmel,at45
 WARNING KERN SPI driver mtd_dataflash has no spi_device_id for atmel,dataflash

Fix this by adding the necessary spi_device_ids.

Fixes: 96c8395e2166 ("spi: Revert modalias changes")
Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20211130112443.107730-1-jonathanh@nvidia.com
This commit is contained in:
Jon Hunter 2021-11-30 11:24:43 +00:00 committed by Miquel Raynal
parent 9472335eaa
commit 27a030e872
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/mtd/devices/mtd_dataflash.c
View File

@ -96,6 +96,13 @@ struct dataflash {
struct mtd_info mtd; struct mtd_info mtd;
}; };
static const struct spi_device_id dataflash_dev_ids[] = {
{ "at45" },
{ "dataflash" },
{ },
};
MODULE_DEVICE_TABLE(spi, dataflash_dev_ids);
#ifdef CONFIG_OF #ifdef CONFIG_OF
static const struct of_device_id dataflash_dt_ids[] = { static const struct of_device_id dataflash_dt_ids[] = {
{ .compatible = "atmel,at45", }, { .compatible = "atmel,at45", },
@ -927,6 +934,7 @@ static struct spi_driver dataflash_driver = {
.name = "mtd_dataflash", .name = "mtd_dataflash",
.of_match_table = of_match_ptr(dataflash_dt_ids), .of_match_table = of_match_ptr(dataflash_dt_ids),
}, },
.id_table = dataflash_dev_ids,
.probe = dataflash_probe, .probe = dataflash_probe,
.remove = dataflash_remove, .remove = dataflash_remove,