iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mm/damon/core: fix a comment about damon_set_attrs() call timings

Browse Source 
The comment on damon_set_attrs() says it should not be called while the
kdamond is running, but now some DAMON modules like sysfs interface and
DAMON_RECLAIM call it from after_aggregation() and/or
after_wmarks_check() callbacks for online tuning.  Update the comment.

Link: https://lkml.kernel.org/r/20230907022929.91361-9-sj@kernel.org
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
SeongJae Park 2023-09-07 02:29:26 +00:00 committed by Andrew Morton
parent 46158bf211
commit 27e68c4b0d
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
mm/damon/core.c
View File

@ -541,7 +541,11 @@ static void damon_update_monitoring_results(struct damon_ctx *ctx,
* @ctx: monitoring context
* @attrs: monitoring attributes
*
* This function should not be called while the kdamond is running.
* This function should be called while the kdamond is not running, or an
* access check results aggregation is not ongoing (e.g., from
* &struct damon_callback->after_aggregation or
* &struct damon_callback->after_wmarks_check callbacks).
*
* Every time interval is in micro-seconds.
*
* Return: 0 on success, negative error code otherwise.