iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

hwmon: (asc7621) Clean up and improve detect function

Browse Source 
* The dev variable is never used.
* Detect functions only need to set info->type, not client->name.
* Include the device address in the log message.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: George Joseph <george.joseph@fairview5.com>
Cc: Ken Milmore <ken.milmore@googlemail.com>
This commit is contained in:
Jean Delvare 2010-08-14 21:08:52 +02:00
parent 738e5e0536
commit 28cbd461f0
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/hwmon/asc7621.c
View File

@ -1150,9 +1150,6 @@ static int asc7621_detect(struct i2c_client *client,
{ {
struct i2c_adapter *adapter = client->adapter; struct i2c_adapter *adapter = client->adapter;
int company, verstep, chip_index; int company, verstep, chip_index;
struct device *dev;
dev = &client->dev;
if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA)) if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
return -ENODEV; return -ENODEV;
@ -1169,13 +1166,11 @@ static int asc7621_detect(struct i2c_client *client,
if (company == asc7621_chips[chip_index].company_id && if (company == asc7621_chips[chip_index].company_id &&
verstep == asc7621_chips[chip_index].verstep_id) { verstep == asc7621_chips[chip_index].verstep_id) {
strlcpy(client->name, asc7621_chips[chip_index].name,
I2C_NAME_SIZE);
strlcpy(info->type, asc7621_chips[chip_index].name, strlcpy(info->type, asc7621_chips[chip_index].name,
I2C_NAME_SIZE); I2C_NAME_SIZE);
dev_info(&adapter->dev, "Matched %s\n", dev_info(&adapter->dev, "Matched %s at 0x%02x\n",
asc7621_chips[chip_index].name); asc7621_chips[chip_index].name, client->addr);
return 0; return 0;
} }
} }