iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

rtc: ds1374, fix lock imbalance

Browse Source 
When i2c_smbus_read_byte_data fails in ds1374_work, we forgot to unlock
the held lock.  Fix that.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Scott Wood <scottwood@freescale.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Jiri Slaby 2009-07-05 12:08:03 -07:00 committed by Linus Torvalds
parent efc0cfa6d1
commit 28df30e61b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/rtc/rtc-ds1374.c
View File

@ -283,7 +283,7 @@ static void ds1374_work(struct work_struct *work)
stat = i2c_smbus_read_byte_data(client, DS1374_REG_SR); stat = i2c_smbus_read_byte_data(client, DS1374_REG_SR);
if (stat < 0) if (stat < 0)
return; goto unlock;
if (stat & DS1374_REG_SR_AF) { if (stat & DS1374_REG_SR_AF) {
stat &= ~DS1374_REG_SR_AF; stat &= ~DS1374_REG_SR_AF;
@ -302,7 +302,7 @@ static void ds1374_work(struct work_struct *work)
out: out:
if (!ds1374->exiting) if (!ds1374->exiting)
enable_irq(client->irq); enable_irq(client->irq);
unlock:
mutex_unlock(&ds1374->mutex); mutex_unlock(&ds1374->mutex);
} }