iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

spi: use gpio[d]_set_value_cansleep for setting chipselect GPIO

Browse Source 
Sleeping is safe inside spi_transfer_one_message, and some
GPIO chips are running on slow busses (such as I2C GPIO
expanders) and need to sleep for setting values.

Signed-off-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Felix Fietkau 2019-02-10 00:38:25 +01:00 committed by Mark Brown
parent 9b4f84212f
commit 28f7604f48
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/spi/spi.c
View File

@ -786,9 +786,10 @@ static void spi_set_cs(struct spi_device *spi, bool enable)
*/
if (!(spi->mode & SPI_NO_CS)) {
if (spi->cs_gpiod)
gpiod_set_value(spi->cs_gpiod, !enable);
gpiod_set_value_cansleep(spi->cs_gpiod,
!enable);
else
gpio_set_value(spi->cs_gpio, !enable);
gpio_set_value_cansleep(spi->cs_gpio, !enable);
}
/* Some SPI masters need both GPIO CS & slave_select */
if ((spi->controller->flags & SPI_MASTER_GPIO_SS) &&