iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bus: imx-weim: Remove open coded "ranges" parsing

Browse Source 
"ranges" is a standard property and we have common helper functions for
parsing it, so let's use them.

Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
This commit is contained in:
Rob Herring 2023-02-01 15:58:54 -06:00 committed by Shawn Guo
parent 189cfa849d
commit 2a88e4792c
1 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
drivers/bus/imx-weim.c
View File

@ -10,6 +10,7 @@
#include <linux/module.h> #include <linux/module.h>
#include <linux/clk.h> #include <linux/clk.h>
#include <linux/io.h> #include <linux/io.h>
#include <linux/of_address.h>
#include <linux/of_device.h> #include <linux/of_device.h>
#include <linux/mfd/syscon.h> #include <linux/mfd/syscon.h>
#include <linux/mfd/syscon/imx6q-iomuxc-gpr.h> #include <linux/mfd/syscon/imx6q-iomuxc-gpr.h>
@ -86,8 +87,8 @@ MODULE_DEVICE_TABLE(of, weim_id_table);
static int imx_weim_gpr_setup(struct platform_device *pdev) static int imx_weim_gpr_setup(struct platform_device *pdev)
{ {
struct device_node *np = pdev->dev.of_node; struct device_node *np = pdev->dev.of_node;
struct property *prop; struct of_range_parser parser;
const __be32 *p; struct of_range range;
struct regmap *gpr; struct regmap *gpr;
u32 gprvals[4] = { u32 gprvals[4] = {
05, /* CS0(128M) CS1(0M) CS2(0M) CS3(0M) */ 05, /* CS0(128M) CS1(0M) CS2(0M) CS3(0M) */
@ -106,13 +107,13 @@ static int imx_weim_gpr_setup(struct platform_device *pdev)
return 0; return 0;
} }
of_property_for_each_u32(np, "ranges", prop, p, val) { if (of_range_parser_init(&parser, np))
if (i % 4 == 0) { goto err;
cs = val;
} else if (i % 4 == 3 && val) { for_each_of_range(&parser, &range) {
val = (val / SZ_32M) | 1; cs = range.bus_addr >> 32;
gprval |= val << cs * 3; val = (range.size / SZ_32M) | 1;
} gprval |= val << cs * 3;
i++; i++;
} }