iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

media: i2c: ccs: replace snprintf in show functions with sysfs_emit

Browse Source 
show() should not use snprintf() when formatting the value to be
returned to user space.

Fix the following coccicheck warning:
drivers/media/i2c/ccs/ccs-core.c:3761: WARNING: use scnprintf or sprintf.

Signed-off-by: Qing Wang <wangqing@vivo.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
This commit is contained in:
Qing Wang 2021-10-18 09:00:36 +01:00 committed by Mauro Carvalho Chehab
parent 85db29d22c
commit 2a99839240
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/media/i2c/ccs/ccs-core.c
View File

@ -2758,13 +2758,13 @@ ident_show(struct device *dev, struct device_attribute *attr, char *buf)
struct ccs_module_info *minfo = &sensor->minfo; struct ccs_module_info *minfo = &sensor->minfo;
if (minfo->mipi_manufacturer_id) if (minfo->mipi_manufacturer_id)
return snprintf(buf, PAGE_SIZE, "%4.4x%4.4x%2.2x\n", return sysfs_emit(buf, "%4.4x%4.4x%2.2x\n",
minfo->mipi_manufacturer_id, minfo->model_id, minfo->mipi_manufacturer_id, minfo->model_id,
minfo->revision_number) + 1; minfo->revision_number) + 1;
else else
return snprintf(buf, PAGE_SIZE, "%2.2x%4.4x%2.2x\n", return sysfs_emit(buf, "%2.2x%4.4x%2.2x\n",
minfo->smia_manufacturer_id, minfo->model_id, minfo->smia_manufacturer_id, minfo->model_id,
minfo->revision_number) + 1; minfo->revision_number) + 1;
} }
static DEVICE_ATTR_RO(ident); static DEVICE_ATTR_RO(ident);