iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HID: sony: Fix memory corruption issue on cleanup.

Browse Source 
The sony driver is not properly cleaning up from potential failures in
sony_input_configured. Currently it calls hid_hw_stop, while hid_connect
is still running. This is not a good idea, instead hid_hw_stop should
be moved to sony_probe. Similar changes were recently made to Logitech
drivers, which were also doing improper cleanup.

Signed-off-by: Roderick Colenbrander <roderick.colenbrander@sony.com>
CC: stable@vger.kernel.org
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
This commit is contained in:
Roderick Colenbrander 2019-09-04 14:22:11 -07:00 committed by Jiri Kosina
parent b20bef4b4b
commit 2bcdacb703
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/hid/hid-sony.c
View File

@ -2811,7 +2811,6 @@ err_stop:
sony_cancel_work_sync(sc); sony_cancel_work_sync(sc);
sony_remove_dev_list(sc); sony_remove_dev_list(sc);
sony_release_device_id(sc); sony_release_device_id(sc);
hid_hw_stop(hdev);
return ret; return ret;
} }
@ -2876,6 +2875,7 @@ static int sony_probe(struct hid_device *hdev, const struct hid_device_id *id)
*/ */
if (!(hdev->claimed & HID_CLAIMED_INPUT)) { if (!(hdev->claimed & HID_CLAIMED_INPUT)) {
hid_err(hdev, "failed to claim input\n"); hid_err(hdev, "failed to claim input\n");
hid_hw_stop(hdev);
return -ENODEV; return -ENODEV;
} }