iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mm/z3fold: throw warning on failure of trylock_page in z3fold_alloc

Browse Source 
If trylock_page fails, the page won't be non-lru movable page.  When this
page is freed via free_z3fold_page, it will trigger bug on PageMovable
check in __ClearPageMovable.  Throw warning on failure of trylock_page to
guard against such rare case just as what zsmalloc does.

Link: https://lkml.kernel.org/r/20220429064051.61552-5-linmiaohe@huawei.com
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Cc: Vitaly Wool <vitaly.wool@konsulko.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
Miaohe Lin 2022-04-29 14:40:43 +08:00 committed by akpm
parent df6f0f1d0c
commit 2c0f351434
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
mm/z3fold.c
View File

@ -1122,10 +1122,9 @@ retry:
__SetPageMovable(page, pool->inode->i_mapping); __SetPageMovable(page, pool->inode->i_mapping);
unlock_page(page); unlock_page(page);
} else { } else {
if (trylock_page(page)) { WARN_ON(!trylock_page(page));
__SetPageMovable(page, pool->inode->i_mapping); __SetPageMovable(page, pool->inode->i_mapping);
unlock_page(page); unlock_page(page);
}
} }
z3fold_page_lock(zhdr); z3fold_page_lock(zhdr);