iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

spi: Fix SPI slave probe failure

Browse Source 
While adding a SPI device, the SPI core ensures that multiple logical CS
doesn't map to the same physical CS. For example, spi->chip_select[0] !=
spi->chip_select[1] and so forth. However, unlike the SPI master, the SPI
slave doesn't have the list of chip selects, this leads to probe failure
when the SPI controller is configured as slave. Update the
__spi_add_device() function to perform this check only if the SPI
controller is configured as master.

Fixes: 4d8ff6b099 ("spi: Add multi-cs memories support in SPI core")
Signed-off-by: Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com>
Link: https://msgid.link/r/20240617153052.26636-1-amit.kumar-mahapatra@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Amit Kumar Mahapatra 2024-06-17 21:00:52 +05:30 committed by Mark Brown
parent d6a711a898
commit 2c1b7bbe25
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/spi/spi.c
View File

@ -689,10 +689,12 @@ static int __spi_add_device(struct spi_device *spi)
* Make sure that multiple logical CS doesn't map to the same physical CS. * Make sure that multiple logical CS doesn't map to the same physical CS.
* For example, spi->chip_select[0] != spi->chip_select[1] and so on. * For example, spi->chip_select[0] != spi->chip_select[1] and so on.
*/ */
for (idx = 0; idx < SPI_CS_CNT_MAX; idx++) { if (!spi_controller_is_target(ctlr)) {
status = spi_dev_check_cs(dev, spi, idx, spi, idx + 1); for (idx = 0; idx < SPI_CS_CNT_MAX; idx++) {
if (status) status = spi_dev_check_cs(dev, spi, idx, spi, idx + 1);
return status; if (status)
return status;
}
} }
/* Set the bus ID string */ /* Set the bus ID string */