iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

netlink: add macro for checking dump ctx size

Browse Source 
We encourage casting struct netlink_callback::ctx to a local
struct (in a comment above the field). Provide a convenience
macro for checking if the local struct fits into the ctx.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Jakub Kicinski 2023-01-04 20:05:21 -08:00
parent 623cd13b16
commit 2c7bc10d0f
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
include/linux/netlink.h
View File

@ -263,6 +263,10 @@ struct netlink_callback {
}; };
}; };
#define NL_ASSET_DUMP_CTX_FITS(type_name) \
BUILD_BUG_ON(sizeof(type_name) > \
sizeof_field(struct netlink_callback, ctx))
struct netlink_notify { struct netlink_notify {
struct net *net; struct net *net;
u32 portid; u32 portid;

2
net/netfilter/nf_conntrack_netlink.c
View File

@ -3866,7 +3866,7 @@ static int __init ctnetlink_init(void)
{ {
int ret; int ret;
BUILD_BUG_ON(sizeof(struct ctnetlink_list_dump_ctx) > sizeof_field(struct netlink_callback, ctx)); NL_ASSET_DUMP_CTX_FITS(struct ctnetlink_list_dump_ctx);
ret = nfnetlink_subsys_register(&ctnl_subsys); ret = nfnetlink_subsys_register(&ctnl_subsys);
if (ret < 0) { if (ret < 0) {