iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

serial: 8250_dw: Use an unified new dev variable in probe

Browse Source 
Use an unified new dev variable instead of &pdev->dev and p->dev
in probe function.

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Kefeng Wang 2016-09-01 10:24:19 +08:00 committed by Greg Kroah-Hartman
parent 41d98b5da9
commit 2cb78eab23
1 changed files with 23 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
drivers/tty/serial/8250/8250_dw.c
View File

@ -360,18 +360,19 @@ static int dw8250_probe(struct platform_device *pdev)
struct resource *regs = platform_get_resource(pdev, IORESOURCE_MEM, 0); struct resource *regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
int irq = platform_get_irq(pdev, 0); int irq = platform_get_irq(pdev, 0);
struct uart_port *p = &uart.port; struct uart_port *p = &uart.port;
struct device *dev = &pdev->dev;
struct dw8250_data *data; struct dw8250_data *data;
int err; int err;
u32 val; u32 val;
if (!regs) { if (!regs) {
dev_err(&pdev->dev, "no registers defined\n"); dev_err(dev, "no registers defined\n");
return -EINVAL; return -EINVAL;
} }
if (irq < 0) { if (irq < 0) {
if (irq != -EPROBE_DEFER) if (irq != -EPROBE_DEFER)
dev_err(&pdev->dev, "cannot get irq\n"); dev_err(dev, "cannot get irq\n");
return irq; return irq;
} }
@ -382,16 +383,16 @@ static int dw8250_probe(struct platform_device *pdev)
p->pm = dw8250_do_pm; p->pm = dw8250_do_pm;
p->type = PORT_8250; p->type = PORT_8250;
p->flags = UPF_SHARE_IRQ | UPF_FIXED_PORT; p->flags = UPF_SHARE_IRQ | UPF_FIXED_PORT;
p->dev = &pdev->dev; p->dev = dev;
p->iotype = UPIO_MEM; p->iotype = UPIO_MEM;
p->serial_in = dw8250_serial_in; p->serial_in = dw8250_serial_in;
p->serial_out = dw8250_serial_out; p->serial_out = dw8250_serial_out;
p->membase = devm_ioremap(&pdev->dev, regs->start, resource_size(regs)); p->membase = devm_ioremap(dev, regs->start, resource_size(regs));
if (!p->membase) if (!p->membase)
return -ENOMEM; return -ENOMEM;
data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL); data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
if (!data) if (!data)
return -ENOMEM; return -ENOMEM;
@ -399,57 +400,57 @@ static int dw8250_probe(struct platform_device *pdev)
data->usr_reg = DW_UART_USR; data->usr_reg = DW_UART_USR;
p->private_data = data; p->private_data = data;
data->uart_16550_compatible = device_property_read_bool(p->dev, data->uart_16550_compatible = device_property_read_bool(dev,
"snps,uart-16550-compatible"); "snps,uart-16550-compatible");
err = device_property_read_u32(p->dev, "reg-shift", &val); err = device_property_read_u32(dev, "reg-shift", &val);
if (!err) if (!err)
p->regshift = val; p->regshift = val;
err = device_property_read_u32(p->dev, "reg-io-width", &val); err = device_property_read_u32(dev, "reg-io-width", &val);
if (!err && val == 4) { if (!err && val == 4) {
p->iotype = UPIO_MEM32; p->iotype = UPIO_MEM32;
p->serial_in = dw8250_serial_in32; p->serial_in = dw8250_serial_in32;
p->serial_out = dw8250_serial_out32; p->serial_out = dw8250_serial_out32;
} }
if (device_property_read_bool(p->dev, "dcd-override")) { if (device_property_read_bool(dev, "dcd-override")) {
/* Always report DCD as active */ /* Always report DCD as active */
data->msr_mask_on |= UART_MSR_DCD; data->msr_mask_on |= UART_MSR_DCD;
data->msr_mask_off |= UART_MSR_DDCD; data->msr_mask_off |= UART_MSR_DDCD;
} }
if (device_property_read_bool(p->dev, "dsr-override")) { if (device_property_read_bool(dev, "dsr-override")) {
/* Always report DSR as active */ /* Always report DSR as active */
data->msr_mask_on |= UART_MSR_DSR; data->msr_mask_on |= UART_MSR_DSR;
data->msr_mask_off |= UART_MSR_DDSR; data->msr_mask_off |= UART_MSR_DDSR;
} }
if (device_property_read_bool(p->dev, "cts-override")) { if (device_property_read_bool(dev, "cts-override")) {
/* Always report CTS as active */ /* Always report CTS as active */
data->msr_mask_on |= UART_MSR_CTS; data->msr_mask_on |= UART_MSR_CTS;
data->msr_mask_off |= UART_MSR_DCTS; data->msr_mask_off |= UART_MSR_DCTS;
} }
if (device_property_read_bool(p->dev, "ri-override")) { if (device_property_read_bool(dev, "ri-override")) {
/* Always report Ring indicator as inactive */ /* Always report Ring indicator as inactive */
data->msr_mask_off |= UART_MSR_RI; data->msr_mask_off |= UART_MSR_RI;
data->msr_mask_off |= UART_MSR_TERI; data->msr_mask_off |= UART_MSR_TERI;
} }
/* Always ask for fixed clock rate from a property. */ /* Always ask for fixed clock rate from a property. */
device_property_read_u32(p->dev, "clock-frequency", &p->uartclk); device_property_read_u32(dev, "clock-frequency", &p->uartclk);
/* If there is separate baudclk, get the rate from it. */ /* If there is separate baudclk, get the rate from it. */
data->clk = devm_clk_get(&pdev->dev, "baudclk"); data->clk = devm_clk_get(dev, "baudclk");
if (IS_ERR(data->clk) && PTR_ERR(data->clk) != -EPROBE_DEFER) if (IS_ERR(data->clk) && PTR_ERR(data->clk) != -EPROBE_DEFER)
data->clk = devm_clk_get(&pdev->dev, NULL); data->clk = devm_clk_get(dev, NULL);
if (IS_ERR(data->clk) && PTR_ERR(data->clk) == -EPROBE_DEFER) if (IS_ERR(data->clk) && PTR_ERR(data->clk) == -EPROBE_DEFER)
return -EPROBE_DEFER; return -EPROBE_DEFER;
if (!IS_ERR_OR_NULL(data->clk)) { if (!IS_ERR_OR_NULL(data->clk)) {
err = clk_prepare_enable(data->clk); err = clk_prepare_enable(data->clk);
if (err) if (err)
dev_warn(&pdev->dev, "could not enable optional baudclk: %d\n", dev_warn(dev, "could not enable optional baudclk: %d\n",
err); err);
else else
p->uartclk = clk_get_rate(data->clk); p->uartclk = clk_get_rate(data->clk);
@ -457,11 +458,11 @@ static int dw8250_probe(struct platform_device *pdev)
/* If no clock rate is defined, fail. */ /* If no clock rate is defined, fail. */
if (!p->uartclk) { if (!p->uartclk) {
dev_err(&pdev->dev, "clock rate not defined\n"); dev_err(dev, "clock rate not defined\n");
return -EINVAL; return -EINVAL;
} }
data->pclk = devm_clk_get(&pdev->dev, "apb_pclk"); data->pclk = devm_clk_get(dev, "apb_pclk");
if (IS_ERR(data->pclk) && PTR_ERR(data->pclk) == -EPROBE_DEFER) { if (IS_ERR(data->pclk) && PTR_ERR(data->pclk) == -EPROBE_DEFER) {
err = -EPROBE_DEFER; err = -EPROBE_DEFER;
goto err_clk; goto err_clk;
@ -469,12 +470,12 @@ static int dw8250_probe(struct platform_device *pdev)
if (!IS_ERR(data->pclk)) { if (!IS_ERR(data->pclk)) {
err = clk_prepare_enable(data->pclk); err = clk_prepare_enable(data->pclk);
if (err) { if (err) {
dev_err(&pdev->dev, "could not enable apb_pclk\n"); dev_err(dev, "could not enable apb_pclk\n");
goto err_clk; goto err_clk;
} }
} }
data->rst = devm_reset_control_get_optional(&pdev->dev, NULL); data->rst = devm_reset_control_get_optional(dev, NULL);
if (IS_ERR(data->rst) && PTR_ERR(data->rst) == -EPROBE_DEFER) { if (IS_ERR(data->rst) && PTR_ERR(data->rst) == -EPROBE_DEFER) {
err = -EPROBE_DEFER; err = -EPROBE_DEFER;
goto err_pclk; goto err_pclk;
@ -506,8 +507,8 @@ static int dw8250_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, data); platform_set_drvdata(pdev, data);
pm_runtime_set_active(&pdev->dev); pm_runtime_set_active(dev);
pm_runtime_enable(&pdev->dev); pm_runtime_enable(dev);
return 0; return 0;