From 2cc1f498623311cb7d1608115b68793bfc505638 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Thu, 21 Sep 2023 09:14:16 +0200 Subject: [PATCH] Revert "configfs: fix a race in configfs_lookup()" This reverts commit c709c7ca020a52ef6530733a9a5f014bd6b71937 which is commit c42dd069be8dfc9b2239a5c89e73bbd08ab35de0 upstream. It was backported incorrectly, and will come back later in a way that actually works. Cc: Sishuai Gong Cc: Christoph Hellwig Cc: Kyle Zeng Reported-by: Guenter Roeck Link: https://lore.kernel.org/r/27f978f3-11ca-6054-5160-ab66d4c918bc@roeck-us.net Signed-off-by: Greg Kroah-Hartman --- fs/configfs/dir.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c index 0b7e9ab517d5..12388ed4faa5 100644 --- a/fs/configfs/dir.c +++ b/fs/configfs/dir.c @@ -479,7 +479,6 @@ static struct dentry * configfs_lookup(struct inode *dir, if (!configfs_dirent_is_ready(parent_sd)) goto out; - spin_lock(&configfs_dirent_lock); list_for_each_entry(sd, &parent_sd->s_children, s_sibling) { if (sd->s_type & CONFIGFS_NOT_PINNED) { const unsigned char * name = configfs_get_name(sd); @@ -492,7 +491,6 @@ static struct dentry * configfs_lookup(struct inode *dir, break; } } - spin_unlock(&configfs_dirent_lock); if (!found) { /*