iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

i2c: cadence: Simplify with dev_err_probe()

Browse Source 
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and the error value gets printed.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
This commit is contained in:
Krzysztof Kozlowski
2020-09-02 17:06:38 +02:00
committed by Wolfram Sang
parent 9dbba3f87c
commit 2d1a83a4f3
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/i2c/busses/i2c-cadence.c
View File

@ -1251,11 +1251,10 @@ static int cdns_i2c_probe(struct platform_device *pdev)
"Cadence I2C at %08lx", (unsigned long)r_mem->start); "Cadence I2C at %08lx", (unsigned long)r_mem->start);
id->clk = devm_clk_get(&pdev->dev, NULL); id->clk = devm_clk_get(&pdev->dev, NULL);
if (IS_ERR(id->clk)) { if (IS_ERR(id->clk))
if (PTR_ERR(id->clk) != -EPROBE_DEFER) return dev_err_probe(&pdev->dev, PTR_ERR(id->clk),
dev_err(&pdev->dev, "input clock not found.\n"); "input clock not found.\n");
return PTR_ERR(id->clk);
}
ret = clk_prepare_enable(id->clk); ret = clk_prepare_enable(id->clk);
if (ret) if (ret)
dev_err(&pdev->dev, "Unable to enable clock.\n"); dev_err(&pdev->dev, "Unable to enable clock.\n");