iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

sched: sched_clock_cpu() based cpu_clock(), lockdep fix

Browse Source 
Vegard Nossum reported:

> WARNING: at kernel/lockdep.c:2738 check_flags+0x142/0x160()

which happens due to:

 unsigned long long cpu_clock(int cpu)
 {
         unsigned long long clock;
         unsigned long flags;

         raw_local_irq_save(flags);

as lower level functions can take locks, we must not do that, use
proper lockdep-annotated irq save/restore.

Reported-by: Vegard Nossum <vegard.nossum@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
This commit is contained in:
Ingo Molnar 2008-06-29 15:01:59 +02:00
parent 4c9fe8ad81
commit 2d452c9b10
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
kernel/sched_clock.c
View File

@ -250,9 +250,9 @@ unsigned long long cpu_clock(int cpu)
unsigned long long clock; unsigned long long clock;
unsigned long flags; unsigned long flags;
raw_local_irq_save(flags); local_irq_save(flags);
clock = sched_clock_cpu(cpu); clock = sched_clock_cpu(cpu);
raw_local_irq_restore(flags); local_irq_restore(flags);
return clock; return clock;
} }