scsi: elx: sli4: Remove code duplication
In the function sli_xmit_bls_rsp64_wqe(), the 'if' and 'else' conditions evaluates the same expression and give the same output. Also, params->s_id shall not be equal to U32_MAX. Remove the unused code. This fixes coccinelle warning such as: drivers/scsi/elx/libefc_sli/sli4.c:2320:2-4: WARNING: possible condition with no effect (if == else) Signed-off-by: Rajeshwar R Shinde <coolrrsh@gmail.com> Link: https://lore.kernel.org/r/20230817114301.17601-1-coolrrsh@gmail.com Reviewed-by: Ram Vegesna <ram.vegesna@broadcom.com> Acked-by: Randy Dunlap <rdunlap@infradead.org> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
parent
56a4d69a26
commit
2d6f70fe17
@ -2317,12 +2317,8 @@ sli_xmit_bls_rsp64_wqe(struct sli4 *sli, void *buf,
|
||||
SLI4_GENERIC_CONTEXT_VPI << SLI4_BLS_RSP_WQE_CT_SHFT;
|
||||
bls->context_tag = cpu_to_le16(params->vpi);
|
||||
|
||||
if (params->s_id != U32_MAX)
|
||||
bls->local_n_port_id_dword |=
|
||||
cpu_to_le32(params->s_id & 0x00ffffff);
|
||||
else
|
||||
bls->local_n_port_id_dword |=
|
||||
cpu_to_le32(params->s_id & 0x00ffffff);
|
||||
bls->local_n_port_id_dword |=
|
||||
cpu_to_le32(params->s_id & 0x00ffffff);
|
||||
|
||||
dw_ridflags = (dw_ridflags & ~SLI4_BLS_RSP_RID) |
|
||||
(params->d_id & SLI4_BLS_RSP_RID);
|
||||
|
Loading…
Reference in New Issue
Block a user