iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

oradax: Fix return value check in dax_attach()

Browse Source 
In case of error, the function class_create() returns ERR_PTR() and
never returns NULL. The NULL test in the return value check should be
replaced with IS_ERR().

Fixes: dd0273284c74 ("sparc64: Oracle DAX driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Wei Yongjun 2018-01-27 08:10:59 +00:00 committed by David S. Miller
parent b3ca676f68
commit 2d85ec8acb
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/sbus/char/oradax.c
View File

@ -336,9 +336,9 @@ static int __init dax_attach(void)
}
cl = class_create(THIS_MODULE, DAX_NAME);
if (cl == NULL) {
if (IS_ERR(cl)) {
dax_err("class_create failed");
ret = -ENXIO;
ret = PTR_ERR(cl);
goto class_error;
}