iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cifsd: remove unneeded FIXME comments

Browse Source 
Remove unneeded FIXME comments.

Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
This commit is contained in:
Sergey Senozhatsky 2021-03-20 16:23:22 +09:00 committed by Steve French
parent 0416536651
commit 2e2b0dda18
12 changed files with 2 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
fs/cifsd/mgmt/share_config.c
View File

@ -16,7 +16,6 @@
#include "user_session.h"
#include "../buffer_pool.h"
#include "../transport_ipc.h"
#include "../ksmbd_server.h" /* FIXME */
#define SHARE_HASH_BITS 3
static DEFINE_HASHTABLE(shares_table, SHARE_HASH_BITS);

2
fs/cifsd/mgmt/share_config.h
View File

@ -10,8 +10,6 @@
#include <linux/hashtable.h>
#include <linux/path.h>
#include "../glob.h" /* FIXME */
struct ksmbd_share_config {
char *name;
char *path;

1
fs/cifsd/mgmt/tree_connect.c
View File

@ -6,7 +6,6 @@
#include <linux/list.h>
#include <linux/slab.h>
#include "../ksmbd_server.h" /* FIXME */
#include "../buffer_pool.h"
#include "../transport_ipc.h"
#include "../connection.h"

2
fs/cifsd/mgmt/tree_connect.h
View File

@ -8,7 +8,7 @@
#include <linux/hashtable.h>
#include "../ksmbd_server.h" /* FIXME */
#include "../ksmbd_server.h"
struct ksmbd_share_config;
struct ksmbd_user;

1
fs/cifsd/mgmt/user_config.c
View File

@ -8,7 +8,6 @@
#include "user_config.h"
#include "../buffer_pool.h"
#include "../transport_ipc.h"
#include "../ksmbd_server.h" /* FIXME */
struct ksmbd_user *ksmbd_login_user(const char *account)
{

3
fs/cifsd/mgmt/user_config.h
View File

@ -6,8 +6,7 @@
#ifndef __USER_CONFIG_MANAGEMENT_H__
#define __USER_CONFIG_MANAGEMENT_H__
#include "../glob.h" /* FIXME */
#include "../ksmbd_server.h" /* FIXME */
#include "../glob.h"
struct ksmbd_user {
unsigned short flags;

1
fs/cifsd/mgmt/user_session.c
View File

@ -14,7 +14,6 @@
#include "../transport_ipc.h"
#include "../connection.h"
#include "../buffer_pool.h"
#include "../ksmbd_server.h" /* FIXME */
#include "../vfs_cache.h"
static struct ksmbd_ida *session_ida;

2
fs/cifsd/server.c
View File

@ -102,8 +102,6 @@ static inline int check_conn_state(struct ksmbd_work *work)
return 0;
}
/* @FIXME what a mess... god help. */
#define TCP_HANDLER_CONTINUE 0
#define TCP_HANDLER_ABORT 1

1
fs/cifsd/smb_common.c
View File

@ -8,7 +8,6 @@
#include "server.h"
#include "misc.h"
#include "smbstatus.h"
/* @FIXME */
#include "connection.h"
#include "ksmbd_work.h"
#include "mgmt/user_session.h"

3
fs/cifsd/transport_ipc.c
View File

@ -28,9 +28,6 @@
#include "connection.h"
#include "transport_tcp.h"
/* @FIXME fix this code */
extern int get_protocol_idx(char *str);
#define IPC_WAIT_TIMEOUT (2 * HZ)
#define IPC_MSG_HASH_BITS 3

1
fs/cifsd/transport_ipc.h
View File

@ -7,7 +7,6 @@
#define __KSMBD_TRANSPORT_IPC_H__
#include <linux/wait.h>
#include "ksmbd_server.h" /* FIXME */
#define KSMBD_IPC_MAX_PAYLOAD 4096

4
fs/cifsd/vfs_cache.c
View File

@ -8,18 +8,14 @@
#include <linux/slab.h>
#include <linux/vmalloc.h>
/* @FIXME */
#include "glob.h"
#include "vfs_cache.h"
#include "buffer_pool.h"
#include "oplock.h"
#include "vfs.h"
#include "connection.h"
#include "mgmt/tree_connect.h"
#include "mgmt/user_session.h"
/* @FIXME */
#include "smb_common.h"
#define S_DEL_PENDING 1