iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dlm: Use kcalloc() in two functions

Browse Source 
* Multiplications for the size determination of memory allocations
  indicated that array data structures should be processed.
  Thus reuse the corresponding function "kcalloc".

  This issue was detected by using the Coccinelle software.

* Replace the specification of data structures by pointer dereferences
  to make the corresponding size determinations a bit safer according to
  the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David Teigland <teigland@redhat.com>
This commit is contained in:
Markus Elfring 2017-05-06 09:34:53 +02:00 committed by David Teigland
parent 790854becc
commit 2f48e06102
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
fs/dlm/member.c
View File

@ -217,8 +217,7 @@ int dlm_slots_assign(struct dlm_ls *ls, int *num_slots, int *slots_size,
} }
array_size = max + need; array_size = max + need;
array = kcalloc(array_size, sizeof(*array), GFP_NOFS);
array = kzalloc(array_size * sizeof(struct dlm_slot), GFP_NOFS);
if (!array) if (!array)
return -ENOMEM; return -ENOMEM;
@ -491,8 +490,7 @@ void dlm_lsop_recover_done(struct dlm_ls *ls)
return; return;
num = ls->ls_num_nodes; num = ls->ls_num_nodes;
slots = kcalloc(num, sizeof(*slots), GFP_KERNEL);
slots = kzalloc(num * sizeof(struct dlm_slot), GFP_KERNEL);
if (!slots) if (!slots)
return; return;