From 2f959949f2149eb0f76aeea8020e8c7865bb0c53 Mon Sep 17 00:00:00 2001 From: Miquel Raynal Date: Thu, 7 May 2020 12:52:32 +0200 Subject: [PATCH] mtd: rawnand: Fix comments about the use of bufpoi Clarify these comments which are not very accurate (even wrong in the read case). Signed-off-by: Miquel Raynal Reviewed-by: Boris Brezillon Link: https://lore.kernel.org/linux-mtd/20200507105241.14299-5-miquel.raynal@bootlin.com --- drivers/mtd/nand/raw/nand_base.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c index 906b8cd94bc4..7dc7889f84b4 100644 --- a/drivers/mtd/nand/raw/nand_base.c +++ b/drivers/mtd/nand/raw/nand_base.c @@ -3279,7 +3279,10 @@ read_retry: break; } - /* Transfer not aligned data */ + /* + * Copy back the data in the initial buffer when reading + * partial pages or when a bounce buffer is required. + */ if (use_bufpoi) { if (!NAND_HAS_SUBPAGE_READ(chip) && !oob && !(mtd->ecc_stats.failed - ecc_failures) && @@ -4074,7 +4077,10 @@ static int nand_do_write_ops(struct nand_chip *chip, loff_t to, else use_bufpoi = 0; - /* Partial page write?, or need to use bounce buffer */ + /* + * Copy the data from the initial buffer when doing partial page + * writes or when a bounce buffer is required. + */ if (use_bufpoi) { pr_debug("%s: using write bounce buffer for buf@%p\n", __func__, buf);