iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[PATCH] Char: mxser_new, remove useless spinlock

Browse Source 
gm_lock is useless, since ISA is configured at init time and there it's
serialized.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Jiri Slaby 2007-02-10 01:45:08 -08:00 committed by Linus Torvalds
parent c76b09301e
commit 30a063a900
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/char/mxser_new.c
View File

@ -313,7 +313,6 @@ static int mxvar_diagflag;
static unsigned char mxser_msr[MXSER_PORTS + 1]; static unsigned char mxser_msr[MXSER_PORTS + 1];
static struct mxser_mon_ext mon_data_ext; static struct mxser_mon_ext mon_data_ext;
static int mxser_set_baud_method[MXSER_PORTS + 1]; static int mxser_set_baud_method[MXSER_PORTS + 1];
static spinlock_t gm_lock;
#ifdef CONFIG_PCI #ifdef CONFIG_PCI
static int __devinit CheckIsMoxaMust(int io) static int __devinit CheckIsMoxaMust(int io)
@ -1377,7 +1376,6 @@ static int __init mxser_program_mode(int port)
{ {
int id, i, j, n; int id, i, j, n;
spin_lock(&gm_lock);
outb(0, port); outb(0, port);
outb(0, port); outb(0, port);
outb(0, port); outb(0, port);
@ -1385,7 +1383,6 @@ static int __init mxser_program_mode(int port)
(void)inb(port); (void)inb(port);
outb(0, port); outb(0, port);
(void)inb(port); (void)inb(port);
spin_unlock(&gm_lock);
id = inb(port + 1) & 0x1F; id = inb(port + 1) & 0x1F;
if ((id != C168_ASIC_ID) && if ((id != C168_ASIC_ID) &&
@ -2684,7 +2681,6 @@ static int __init mxser_module_init(void)
mxvar_sdriver = alloc_tty_driver(MXSER_PORTS + 1); mxvar_sdriver = alloc_tty_driver(MXSER_PORTS + 1);
if (!mxvar_sdriver) if (!mxvar_sdriver)
return -ENOMEM; return -ENOMEM;
spin_lock_init(&gm_lock);
printk(KERN_INFO "MOXA Smartio/Industio family driver version %s\n", printk(KERN_INFO "MOXA Smartio/Industio family driver version %s\n",
MXSER_VERSION); MXSER_VERSION);