iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

livepatch: Convert error about unsupported reliable stacktrace into a warning

Browse Source 
The commit d0807da78e ("livepatch: Remove immediate feature") caused
that any livepatch was refused when reliable stacktraces were not supported
on the given architecture.

The limitation is too strong. User space processes are safely migrated
even when entering or leaving the kernel. Kthreads transition would
need to get forced. But it is safe when:

   + The livepatch does not change the semantic of the code.
   + Callbacks do not depend on a safely finished transition.

Suggested-by: Josh Poimboeuf <jpoimboe@redhat.com>
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
Acked-by: Miroslav Benes <mbenes@suse.cz>
Reviewed-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Signed-off-by: Petr Mladek <pmladek@suse.com>
This commit is contained in:
Petr Mladek 2019-04-24 10:55:48 +02:00
parent 43bd3a95c9
commit 31adf2308f
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
kernel/livepatch/core.c
View File

@ -1003,11 +1003,10 @@ int klp_enable_patch(struct klp_patch *patch)
return -ENODEV; return -ENODEV;
if (!klp_have_reliable_stack()) { if (!klp_have_reliable_stack()) {
pr_err("This architecture doesn't have support for the livepatch consistency model.\n"); pr_warn("This architecture doesn't have support for the livepatch consistency model.\n");
return -EOPNOTSUPP; pr_warn("The livepatch transition may never complete.\n");
} }
mutex_lock(&klp_mutex); mutex_lock(&klp_mutex);
ret = klp_init_patch_early(patch); ret = klp_init_patch_early(patch);