iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ocxl: read_pasid never returns an error, so make it void

Browse Source 
No need for a return value in read_pasid as it only returns 0.

Signed-off-by: Alastair D'Silva <alastair@d-silva.org>
Reviewed-by: Greg Kurz <groug@kaod.org>
Acked-by: Frederic Barrat <fbarrat@linux.ibm.com>
Acked-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
This commit is contained in:
Alastair D'Silva 2019-03-25 16:34:53 +11:00 committed by Michael Ellerman
parent 9c4ae06456
commit 32941494ff
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/misc/ocxl/config.c
View File

@ -68,7 +68,7 @@ static int find_dvsec_afu_ctrl(struct pci_dev *dev, u8 afu_idx)
return 0; return 0;
} }
static int read_pasid(struct pci_dev *dev, struct ocxl_fn_config *fn) static void read_pasid(struct pci_dev *dev, struct ocxl_fn_config *fn)
{ {
u16 val; u16 val;
int pos; int pos;
@ -89,7 +89,6 @@ static int read_pasid(struct pci_dev *dev, struct ocxl_fn_config *fn)
out: out:
dev_dbg(&dev->dev, "PASID capability:\n"); dev_dbg(&dev->dev, "PASID capability:\n");
dev_dbg(&dev->dev, " Max PASID log = %d\n", fn->max_pasid_log); dev_dbg(&dev->dev, " Max PASID log = %d\n", fn->max_pasid_log);
return 0;
} }
static int read_dvsec_tl(struct pci_dev *dev, struct ocxl_fn_config *fn) static int read_dvsec_tl(struct pci_dev *dev, struct ocxl_fn_config *fn)
@ -205,11 +204,7 @@ int ocxl_config_read_function(struct pci_dev *dev, struct ocxl_fn_config *fn)
{ {
int rc; int rc;
rc = read_pasid(dev, fn); read_pasid(dev, fn);
if (rc) {
dev_err(&dev->dev, "Invalid PASID configuration: %d\n", rc);
return -ENODEV;
}
rc = read_dvsec_tl(dev, fn); rc = read_dvsec_tl(dev, fn);
if (rc) { if (rc) {