iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fpga: stratix10-soc: fix wrong of_node_put() in init function

Browse Source 
After finding a "firmware" dt node stratix10 tries to match it's
compatible string with it. To do so it's calling of_find_matching_node()
which already takes care of decreasing the refcount on the "firmware"
node. We are then incorrectly decreasing the refcount on that node
again.

This patch removes the unwarranted call to of_node_put().

Fixes: e7eef1d763 ("fpga: add intel stratix10 soc fpga manager driver")
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Acked-by: Alan Tull <atull@kernel.org>
Acked-by: Moritz Fischer <mdf@kernel.org>
[atull: remove unnecessary braces]
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Nicolas Saenz Julienne 2019-01-26 10:38:29 -06:00 committed by Greg Kroah-Hartman
parent 5aa608348f
commit 32a6637448
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/fpga/stratix10-soc.c
View File

@ -508,14 +508,11 @@ static int __init s10_init(void)
return -ENODEV; return -ENODEV;
np = of_find_matching_node(fw_np, s10_of_match); np = of_find_matching_node(fw_np, s10_of_match);
if (!np) { if (!np)
of_node_put(fw_np);
return -ENODEV; return -ENODEV;
}
of_node_put(np); of_node_put(np);
ret = of_platform_populate(fw_np, s10_of_match, NULL, NULL); ret = of_platform_populate(fw_np, s10_of_match, NULL, NULL);
of_node_put(fw_np);
if (ret) if (ret)
return ret; return ret;