iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

phy: stm32: fix error return in stm32_usbphyc_phy_init

Browse Source 
Error code is overridden, in case the PLL doesn't lock. So, the USB
initialization can continue. This leads to a platform freeze.
This can be avoided by returning proper error code to avoid USB probe
freezing the platform. It also displays proper errors in log.

Fixes: 5b1af71280ab ("phy: stm32: rework PLL Lock detection")
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Link: https://lore.kernel.org/r/20220713133953.595134-1-fabrice.gasnier@foss.st.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
Fabrice Gasnier 2022-07-13 15:39:53 +02:00 committed by Vinod Koul
parent 08fd292fdf
commit 32b378a917
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/phy/st/phy-stm32-usbphyc.c
View File

@ -358,7 +358,9 @@ static int stm32_usbphyc_phy_init(struct phy *phy)
return 0; return 0;
pll_disable: pll_disable:
return stm32_usbphyc_pll_disable(usbphyc); stm32_usbphyc_pll_disable(usbphyc);
return ret;
} }
static int stm32_usbphyc_phy_exit(struct phy *phy) static int stm32_usbphyc_phy_exit(struct phy *phy)